setup should unregister existing install in case of reboot necessary

Bug #274628 reported by Mark Hammond
2
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Medium
Unassigned
Bazaar Windows Installers
Incomplete
Undecided
Unassigned
TortoiseBZR
Incomplete
Low
Unassigned

Bug Description

If we upgrade while tbzr is running, then inno setup offers to reboot - but between clicking OK and the reboot actually happening, TBZR restarts itself - but it will be in an inconsistent state, as some files have been updated but others have not.

The installer should probably ask the existing installation to unregister its COM objects, so they won't be reused by explorer until the reboot actually happens and reregistration occurs.

Revision history for this message
Mark Hammond (mhammond) wrote :

Affects bzr as it's bzr.iss.cog is where this must live.

Jelmer Vernooij (jelmer)
Changed in bzr:
importance: Undecided → Medium
status: New → Triaged
Changed in tortoisebzr:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
methane (songofacandy) wrote :

Now Windows Installer is not affects bzr core project.

Changed in bzr:
status: Triaged → Invalid
Revision history for this message
methane (songofacandy) wrote :

Is this bug still live?

I think "restartreplace" uses MoveFileEx with MOVEFILE_DELAY_UNTIL_REBOOT flag and move file in boot time.
So TortoiseBZR should not work when replacing dll/exe files.

methane (songofacandy)
Changed in bzr-windows-installers:
status: New → Incomplete
Changed in tortoisebzr:
status: Triaged → Incomplete
methane (songofacandy)
Changed in tortoisebzr:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.