Please apply patch to fix issue with Si3054 modems

Bug #269855 reported by أحمد المحمودي (Ahmed El-Mahmoudy)
4
Affects Status Importance Assigned to Milestone
sl-modem (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Hello,

  There is a problem with Si3054 modems that makes one not able to dial, please refer to this thread: http://linmodems.technion.ac.il/archive-seventh/msg01937.htm

I have prepared a package for sl-modem with the patch that fixes it, the patch is from: http://helllabs.org/patch/20070710_slmodem/slmodem-2.9.11-alsa-period-size.patch

I tested the package and it worked when I disable carrier checking in wvdial (Carrier Check = no).

Please find the attached debdiff which is against sl-modem_2.9.10+2.9.9d+e-pre2-5ubuntu4

Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote :
Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote : New package available

Hello,

  I prepared a package for the latest upstream release of sl-modem.
  The package can be found on mentors.debian.net:
  - URL: http://mentors.debian.net/debian/pool/non-free/s/sl-modem
  - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
  - dget http://mentors.debian.net/debian/pool/non-free/s/sl-modem/sl-modem_2.9.11~20080817-1.dsc

  Please test it and report if your bugs got solved and any suggestions you've got.

  Thanks.

--
 أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
  SySDSoft, Inc.
 GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net)
 GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27

Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote :

Hello,

  For those who need a binary package, I have uploaded the package to my
  PPA (https://launchpad.net/~aelmahmoudy/+archive), also fixed an FTBFS
  for Intrepid. Binary packages for Hardy and Intrepid are available.

--
 أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
  SySDSoft, Inc.
 GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net)
 GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

I see version in your PPA contains lots of fixes, mind preparing an updated debdiff for review?

Changed in sl-modem:
importance: Undecided → Medium
Changed in sl-modem:
status: New → In Progress
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Debian has 2.9.11~20080817-1, mind preparing a merge/sync request for it?

Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote : Re: [Bug 269855] Re: Please apply patch to fix issue with Si3054 modems

Thanks !

Sync request is on:
https://bugs.launchpad.net/ubuntu/+source/sl-modem/+bug/295677

--
 أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
  SySDSoft, Inc.
 GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net)
 GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.2 KiB)

This bug was fixed in the package sl-modem - 2.9.11~20080817-1

---------------
sl-modem (2.9.11~20080817-1) unstable; urgency=medium

  * New upstream release. (Closes: #354908, #489289, #457637, LP: #144090, #269855)
  * Adopting sl-modem. (Closes: #471888)
  * Removed the following patches since they are applied upstream:
    + patch to define URB_ASYNC_UNLINK if not set
    + patch that adds alternative MODULE_PARM function (module_param)
    + patch removing the inclusion of config.h
    + patch making a biarch build with lib32 package versions
    + patches fixing buils with kernel versions 2.6.16, 2.6.18 and 2.6.26
  * Remove cmd.patch and pcireg.patch as they are applied upstream.
  * Used quilt patch system.
    + Moved slmodem-class-simple-to-class-meins.diff to debian/patches/
    + 01_Makefile.diff: Makefile cleanup to not loose the user-specified
      kernel version string.
    + modem_group.diff: set the default device group to "dialout".
    + 02_dial_string_size.diff: enlarge dial string buffer to 128 bytes
    + 03_Makefile_2.6.12.4.diff: workaround in drivers/Makefile for a kernel
      2.4 check accidentialy matching 2.6.12.4.
    + 04_sregs_init.diff
    + 05_st7554_license.diff: changed the MODULE_LICENSE string to
      "Dual BSD/GPL" since the license is actually a BSD license clone.
    + 06_slmodem-class-simple-to-class-meins.diff: patch for
      class/simple_class transition.
    + 08_ungrab_winmodem.diff: helper module to tell the kernel to keep away
      from unsupported PCI id numbers.
    + 10_drop_privileges.diff: slmodemd privilege dropping patch.
    + 11_logfile.diff: place debug log in /var/log/slmodem.log.
    + kernel-ver.diff: workaround for pre-2.6.18 kernels.
    + README.diff: Dropped the TROUBLESHOOTING section from README and adapted
      the feedback section, mentioned the transfer of the modem business to
      Conexant.
    + debug_level.diff: debug log file is not for end users. Users shall use
      -l <number>.
  * Added fortify_source.diff patch to fix FTBFS with -D_FORTIFY_SOURCE=2
    compile flag.
  * Synch'ed ungrab-winmodem.c from
    http://linmodems.technion.ac.il/packages/smartlink/ungrab-winmodem-20080126.tar.gz.
  * Remove debian/control.backup* as I don't see any use for them.
  * Update Standards-Version to 3.8.0.
  * Added watch file.
  * debian/rules: slusb support ends at 2.6.24, hence add a check for kernel
    sublevel, to prevent the attempt to install non-existing slusb.ko. Thanks
    to Maurizio Avogadro for the suggestion.
  * Translation updates: Swedish, German, Basque, French, Italian, Czech,
    Portuguese, Finnish, Japanese and Russian (Closes: #501038, #501043,
    #501065, #501102, #501108, #501213, #501225, #501701, #501632, #501593).
  * New translation: Arabic (Closes: #501196).
  * debian/control: Added Maurizio Avogadro to Uploaders field.
  * debian/sl-modem-daemon.init: changes from Ubuntu
    + sl-modem-daemon initscript waits for aplay (from alsa-utils) to report
      the card, as it appears in /proc/asound/cards before it is actually
      available to slmodemd. This extra check defeats this race.
    + Remove hard and soft ulimits for locked-in-cor...

Read more...

Changed in sl-modem:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.