quagga: Repeat of #315467: So-called "fix" doesn't resolve the actual problem.

Automatically imported from Debian bug report #340565 http://bugs.debian.org/340565

Message-Id: <email address hidden>
Date: Thu, 24 Nov 2005 09:28:52 +0100
From: Rens Houben <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: quagga: Repeat of #315467: So-called "fix" doesn't resolve the actual
 problem.

Package: quagga
Version: 0.99.2-1
Severity: grave
Tags: patch
Justification: causes non-serious data loss

The problem described in #315467 (all negotiated routes get dropped
during a restart of quagga) is in fact *not* due to the "simple concept
of a daemon restarting" as you implied -- in fact, the quagga authors
already thought long and hard about that possible issue and allowed for
it: When starting any of the quagga daemons with the --retain flag, that
daemon will not flush its routes when exiting.

The *real* cause of the problem is the explicit route flush you added in
the /etc/init.d/quagga script at the "stop" case. It's not only
unneccessary (because each daemon can be configured via
/etc/quagga/debian.conf to either flush or retain its routes), it's
dangerous.

Removing line 225 and 226 from /etc/init.d/quagga fixes the problem
without requiring a debconf prompt not to restart quagga ever.

-- System Information:
Debian Release: testing/unstable
  APT prefers stable
  APT policy: (900, 'stable'), (100, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages quagga depends on:
ii adduser 3.79 Add and remove users and groups
ii debconf [debconf-2.0] 1.4.59 Debian configuration management sy
ii iproute 20041019-4 Professional tools to control the
ii libc6 2.3.5-8 GNU C Library: Shared libraries an
ii libcap1 1:1.10-14 support for getting/setting POSIX.
ii libncurses5 5.5-1 Shared libraries for terminal hand
ii libpam0g 0.79-3 Pluggable Authentication Modules l
ii libreadline5 5.0-11 GNU readline and history libraries
ii logrotate 3.7.1-2 Log rotation utility

quagga recommends no packages.

-- debconf information:
* quagga/really_stop: true

Message-ID: <email address hidden>
Date: Mon, 28 Nov 2005 00:57:47 +0100
From: Christian Hammers <email address hidden>
To: Rens Houben <email address hidden>, <email address hidden>
Subject: Re: Bug#340565: quagga: Repeat of #315467: So-called "fix" doesn't
 resolve the actual problem.

Hello Rens

I've just replied you in bug report #315467, please keep the discussion
there. I close this as dublicate.

bye,

-christian-

Rejected upstream