Launchpad itself

bzr+http branches will be completely remirrored every time the puller runs

Bug #260219 reported by Michael Hudson-Doyle
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Hudson-Doyle
Launchpad itself 2.1.10

Bug Description

I haven't tested this, but I am *pretty sure* that the puller will successfully mirror a branch over bzr+http now but when the time comes to update the mirror it will think the format has changed (because RemoteRepository is a different type to KnitPackRepository...), throw away it's copy of the mirror and completely remirror the branch, wasting heaps of bandwidth both for us (who can probably cope) and whoever is hosting the branch (who may not be best pleased).

Tags: lp-code
Michael Hudson-Doyle (mwhudson)
Changed in launchpad-bazaar:
importance: Undecided → High
Revision history for this message
Robert Collins (lifeless) wrote :

sounds plausible.

The general problem here is you can't tell what the remote format is, in principle. But today,we don't have fully VFS free remote servers, so just type check for Remote* and call _real_FOO to get the one to check.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I guess another approach would be "it's a Remote*, so if the local branch is in the default format that's good enough". But type checking and _real fishing sounds like a good enough start.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Well, actually they won't be re-mirrored because of bug 260972. But this should still be fixed...

Revision history for this message
Jonathan Lange (jml) wrote :

I believe Michael is working on this.

Changed in launchpad-bazaar:
assignee: nobody → mwhudson
status: New → In Progress
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

RF launchpad/devel 6911

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

Assigning to 2.1.9, since it's committed and unreleased.

Changed in launchpad-bazaar:
milestone: none → 2.1.9
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So I fixed a problem, but the bug remains because of format issues -- we need to upgrade bazaar to fix them.

Changed in launchpad-bazaar:
milestone: 2.1.9 → 2.1.10
status: Fix Committed → In Progress
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The Bazaar upgrade landed.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

2.1.10

Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.