Ubuntu
collectd package

collectd FTBFS in intrepid

Bug #255837 reported by Devid Antonio Filoni on 2008-08-07

Affects		Status	Importance	Assigned to	Milestone
	collectd (Ubuntu)	Fix Released	Medium	Devid Antonio Filoni

Bug Description

Binary package hint: collectd

collectd FTBFS in intrepid.

Related branches

lp:ubuntu/karmic/collectd

Revision history for this message

Devid Antonio Filoni (d.filoni) wrote on 2008-08-07:

I'm working on this.

Changed in collectd:
assignee:	nobody → d.filoni
status:	New → In Progress

Revision history for this message

Devid Antonio Filoni (d.filoni) wrote on 2008-08-07:

collectd_4.4.1-1ubuntu1.debdiff Edit (3.3 KiB, text/plain)

The debdiff

Changed in collectd:
assignee:	d.filoni → nobody
status:	In Progress → Confirmed

Revision history for this message

Luca Falavigna (dktrkranz) wrote on 2008-09-21:

Devid, you're a MOTU now, I'll leave this upload to you, thanks!

Changed in collectd:
assignee:	nobody → d.filoni
importance:	Undecided → Medium

Revision history for this message

Reinhard Tartler (siretart) wrote on 2008-09-21:

could you please improve the comments on your patches?
that way they are unlikely to get accepted upstream, because they are not self explanatory at all

Revision history for this message

Launchpad Janitor (janitor) wrote on 2008-10-18:

This bug was fixed in the package collectd - 4.4.1-1ubuntu1

---------------
collectd (4.4.1-1ubuntu1) intrepid; urgency=low

* Add in6-glibc28.dpatch patch, fix FTBFS (LP: #255837).
* Add ubuntu_hardening.dpatch patch, fix FTBFS.

-- Devid Antonio Filoni <email address hidden> Thu, 07 Aug 2008 21:00:53 +0200

Changed in collectd:
status:	Confirmed → Fix Released

Revision history for this message

Reinhard Tartler (siretart) wrote on 2008-10-18: Re: [Bug 255837] Re: collectd FTBFS in intrepid

I'm very sorry to see that you have (knowningly or unknowningly) ignored
my comment [1] on this bug.

[1] https://bugs.edge.launchpad.net/ubuntu/+source/collectd/+bug/255837/comments/4

Have you talked to upstream about this? The package you have uploaded
still does not properly explain why these changes fix the package, and
something like this WILL be necessary for debian squeeze.

Again, please do forward this patch upstream and get it properly
integrated.

Launchpad Bug Tracker <email address hidden> writes:

> This bug was fixed in the package collectd - 4.4.1-1ubuntu1
>
> ---------------
> collectd (4.4.1-1ubuntu1) intrepid; urgency=low
>
> * Add in6-glibc28.dpatch patch, fix FTBFS (LP: #255837).
> * Add ubuntu_hardening.dpatch patch, fix FTBFS.
>
> -- Devid Antonio Filoni <email address hidden> Thu, 07 Aug 2008
> 21:00:53 +0200
>
> ** Changed in: collectd (Ubuntu)
> Status: Confirmed => Fix Released

--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Revision history for this message

Devid Antonio Filoni (d.filoni) wrote on 2008-10-18:

Ehm... I haven't uploaded the package, as you can see I haven't signed it...
I'm sending the patch to upstream, don't worry ;)

Thanks for this email.

Devid Antonio Filoni

On Sat, Oct 18, 2008 at 9:27 PM, Reinhard Tartler <email address hidden> wrote:
>
> I'm very sorry to see that you have (knowningly or unknowningly) ignored
> my comment [1] on this bug.
>
> [1] https://bugs.edge.launchpad.net/ubuntu/+source/collectd/+bug/255837/comments/4
>
> Have you talked to upstream about this? The package you have uploaded
> still does not properly explain why these changes fix the package, and
> something like this WILL be necessary for debian squeeze.
>
> Again, please do forward this patch upstream and get it properly
> integrated.
>
>
> Launchpad Bug Tracker <email address hidden> writes:
>
>> This bug was fixed in the package collectd - 4.4.1-1ubuntu1
>>
>> ---------------
>> collectd (4.4.1-1ubuntu1) intrepid; urgency=low
>>
>> * Add in6-glibc28.dpatch patch, fix FTBFS (LP: #255837).
>> * Add ubuntu_hardening.dpatch patch, fix FTBFS.
>>
>> -- Devid Antonio Filoni <email address hidden> Thu, 07 Aug 2008
>> 21:00:53 +0200
>>
>> ** Changed in: collectd (Ubuntu)
>> Status: Confirmed => Fix Released
>
> --
> Gruesse/greetings,
> Reinhard Tartler, KeyID 945348A4
>
> --
> Ubuntu-motu mailing list
> <email address hidden>
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu
>

Revision history for this message

Sebastian Harl (tokkee) wrote on 2008-10-19:

Hi Devid,

On Sat, Oct 18, 2008 at 07:51:03PM -0000, Devid Antonio Filoni wrote:
> Ehm... I haven't uploaded the package, as you can see I haven't signed it...
> I'm sending the patch to upstream, don't worry ;)

Thanks for sending the glibc-2.8 fix to the collectd mailing list.

It would be nice though, if you could comment the hardening patch. Imho,
this does not fix anything but rather just hide some compiler warning. A
real fix would report an error and then act appropriately (I assume that
aborting the read makes the most sense but I did not look into the code
of the multimeter plugin yet).

Cheers,
Sebastian

--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin

Revision history for this message

Sebastian Harl (tokkee) wrote on 2008-11-25:

Hi Devid,

On Sun, Oct 19, 2008 at 05:27:22PM +0200, Sebastian Harl wrote:
> It would be nice though, if you could comment the hardening patch. Imho,
> this does not fix anything but rather just hide some compiler warning. A
> real fix would report an error and then act appropriately (I assume that
> aborting the read makes the most sense but I did not look into the code
> of the multimeter plugin yet).

Please note that a real fix is now available in the upstream Git reposi-
tory [1].

HTH,
Sebastian

[1] http://git.verplant.org/?p=collectd.git;a=commit;h=3e429a6

--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin