Can't request a review for a merge

I can confirm this (if i click request review, i get a traceback too).

It's worth noting that a subscriber to the target branch (the strange "schooltool checkins" user -- not a team -- doesn't have a public email address. But I can't reproduce the problem locally, so maybe that's a red herring.

I think that this bug is due to the "Request a review" needing edit permissions, whereas any person can comment.

Edit permissions are granted to the person who requested the proposal, and to those that can edit the source or target branches.

No, I don't think so: I suggest you try it :) The end of the traceback is:

    * Module zope.component.site, line 89, in subscribers
      return self.adapters.subscribers(required, provided)
    * Module zope.interface.adapter, line 481, in subscribers
      subscribers = [subscription(*objects)
    * Module canonical.launchpad.mailout.branchmergeproposal, line 31, in send_merge_proposal_modified_notifications
      mailer.sendAll()
    * Module canonical.launchpad.mailout.basemailer, line 100, in sendAll
      to_address = format_address(

Unauthorized: (<EmailAddress at 0x9a21310>, 'email', 'launchpad.View')

> Edit permissions are granted to the person who requested the proposal,
> and to those that can edit the source or target branches.

But we have tried doing that using the aelkner user (he definitely can
edit his own branch) and both of us can edit the schooltool.cas branch
that belongs to schooltool-owners group, though I (ignas) have
requested the merge, so it might be that I can't request a review
because I can't edit aelkner's branch, and he can't request the review
because he can't edit the merge request...

Ignas

This is a regression caused by the new restrictions for non-publicly-disclosed-emails. If nobody is working on this I can give it a go today.

I am. Have an almost ready branch.

On Fri, Jul 18, 2008 at 10:55 PM, Guilherme Salgado
<email address hidden> wrote:
> This is a regression caused by the new restrictions for non-publicly-
> disclosed-emails. If nobody is working on this I can give it a go
> today.
>
> --
> Can't request a review for a merge
> https://bugs.launchpad.net/bugs/247814
> You received this bug notification because you are subscribed to
> Launchpad Bazaar Integration.
>

This one is hitting Storm now too, since someone with a private email address has subscribed to the trunk branch.

Is this limited to the "request a review" form, or does it also affect other aspects like commenting on reviews?

jml: was this completed before the 2.0 release?

The commit was RF 6754. According to the website, this was a part of 2.0.