Package diffs should be viewable inline, not only downloaded

Bug #246534 reported by Matt Zimmerman
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Celso Providelo

Bug Description

I was very pleased to see the package diff links in the source package history. Kudos on this useful feature.

However, I was somewhat disappointed to find that clicking on the link did not display the diff, but only offered a gzip archive for download. Particularly for small diffs (the common case), it would be much more useful to be able to view these diffs directly in the browser, rather than downloading them. Of course, some diffs are huge and wouldn't be as useful to see in the browser, but perhaps we could have the best of both worlds with both "view" and "download" hyperlinks.

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

This seems like a straightforward usability fix.

Changed in soyuz:
importance: Undecided → High
status: New → Confirmed
Celso Providelo (cprov)
Changed in soyuz:
assignee: nobody → cprov
milestone: none → 2.1.9
status: Confirmed → Triaged
Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 246534] Re: Package diffs should be viewable inline, not only downloaded

On Thu, Aug 21, 2008 at 12:05:10PM -0000, Mark Shuttleworth wrote:
> This seems like a straightforward usability fix.

I'm told this is actually a fairly involved issue in the librarian, and that
there's another bug report open about it. I can't find it, though.

--
 - mdz

Revision history for this message
Celso Providelo (cprov) wrote :

The librarian issue mentioned above is reported as bug 174204.

Revision history for this message
Celso Providelo (cprov) wrote :

We can easily extend the 'hack' used for buildlogs ('txt.gz') for all 'diff.gz' files and it would also include source diffs, not only package-diffs. I will ask around if it may cause any discomfort.

Celso Providelo (cprov)
Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Celso Providelo (cprov) wrote :

RF 6894

Changed in soyuz:
status: In Progress → Fix Committed
Revision history for this message
Christian Reis (kiko) wrote :

Fixed on lpnet; enjoy!

Changed in soyuz:
status: Fix Committed → Fix Released
Revision history for this message
Matt Zimmerman (mdz) wrote :

On Fri, Aug 22, 2008 at 11:57:28PM -0000, Christian Reis wrote:
> Fixed on lpnet; enjoy!
>
> ** Changed in: soyuz
> Status: Fix Committed => Fix Released

It works! You are my heroes.

--
 - mdz

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.