Close window has the same accelerator on Close and Cancel

Bug #245733 reported by Mackenzie Morgan
2
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
High
Mackenzie Morgan

Bug Description

They both use Alt+C, so that won't work. One of the button's got to use some other letter.

Revision history for this message
Mackenzie Morgan (maco.m) wrote :
Revision history for this message
Mackenzie Morgan (maco.m) wrote :

Or for that matter, since the meaning of the buttons could be ambiguous, how about "_Close Anyway" and "_Keep Open"

Revision history for this message
Mackenzie Morgan (maco.m) wrote :

Fixed version linked by Daniel Chen. Buttons now are stock "_Cancel" and "Close _All Terminals" with the "Close _All Terminals" button still having the close icon (because I'm anal and didn't want the icon to go away like how there's no icon in gnome-terminal's close-all button)

Changed in terminator:
assignee: nobody → maco.m
status: New → In Progress
Revision history for this message
chantra (chantra) wrote : Re: [Bug 245733] Re: Close window has the same accelerator on Close and Cancel



 status confirmed
 importance high

hi,

As we try to stay as close as possible to gnome-terminal, Maybe it
should be:
_Cancel
and
Close All _Terminals .

The .pot while has been uploaded already, so I am not sure this will
make it into 0.9 .

On Sat, 2008-07-05 at 05:02 +0000, Mackenzie Morgan wrote:
> Fixed version linked by Daniel Chen. Buttons now are stock "_Cancel"
> and "Close _All Terminals" with the "Close _All Terminals" button still
> having the close icon (because I'm anal and didn't want the icon to go
> away like how there's no icon in gnome-terminal's close-all button)
>
> ** Changed in: terminator
> Assignee: (unassigned) => Mackenzie Morgan (maco.m)
> Status: New => In Progress
>
--
http://www.debuntu.org

Debuntu deb's repository

Changed in terminator:
importance: Undecided → High
status: In Progress → Confirmed
Revision history for this message
Mackenzie Morgan (maco.m) wrote :

The string in the dialog is "close all terminals" as well, so shouldn't the translations on both strings match anyway? The .pot shouldn't be too affected.

Revision history for this message
Chris Jones (cmsj) wrote :

Thanks, I have pushed this to trunk.

Changed in terminator:
status: Confirmed → Fix Committed
Revision history for this message
Mackenzie Morgan (maco.m) wrote :

Closing

Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.