code review emails do not make it obvious which branch merge proposal they are for
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Tim Penhey | ||
Bug Description
I received the following email from Launchpad:
Reply-To: <email address hidden>
Message-Id: <email address hidden>
X-Launchpad
X-Launchpad
To: James Henstridge <email address hidden>
From: Christopher Armstrong <email address hidden>
Subject: Is this subject required?
Date: Mon, 16 Jun 2008 12:58:57 -0000
Sender: <email address hidden>
Errors-To: <email address hidden>
Precedence: bulk
X-Generated-By: Launchpad (canonical.com)
Vote: Approve
Looks good! Thanks.
--
You are subscribed to branch Storm Development Branch.
While the email tells me that I got the email because I subscribed to ~storm/storm/trunk, it doesn't tell me which merge proposal it is for (other than checking the Reply-To header and trying to match the numeric ID).
Ideally there would be a link to the merge proposal and a maybe some text naming the two branches (having the lp: URLs for the two wouldn't be out of place).
| Changed in launchpad-bazaar: | |
| status: | New → Confirmed |
| Tim Penhey (thumper) wrote | #1 |
| Changed in launchpad-bazaar: | |
| assignee: | nobody → thumper |
| importance: | Undecided → High |
| milestone: | none → 1.2.6 |
| status: | Confirmed → In Progress |
| Tim Penhey (thumper) wrote | #2 |
| Changed in launchpad-bazaar: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-bazaar: | |
| status: | Fix Committed → Fix Released |
Adding the URL of the code review in the footer of the email. This includes the unique name of the source branch, so I decided on not duplicating the source branch explicitly in the footer.