collective.buildout

plone.recipe.zope2instance exit status when running test

Bug #232500 reported by Sylvain Viollon
2
Affects Status Importance Assigned to Milestone
collective.buildout
Won't Fix
High
Unassigned

Bug Description

I am working with 'collective.buildbot'. It expect that testing command return an exit status different of 0 when test fails.
If we use:

  ./bin/instance test

With 'instance' created with 'plone.recipe.zope2instance', the exit status is always 0, even if test fails. Can we fix this, even for test ran with Zope 2.8 ?

Revision history for this message
Hanno Schlichting (hannosch) wrote :

I'd very much would like that.

In fact I had been looking into this but without success so far. You need a newer zope.testing which has the --exit-status support, or you won't get anything useful from the test runner. But if the test runner supports it, we should pass on the return value.

Changed in collective.buildout:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Sylvain Viollon (thefunny) wrote :

With you use Zope 2.9+, and add 'zope.testing == 3.5' as dependency to your instance generated with 'plone.recipe.zope2instance' you get an option '--with-exit-status' which works. As well, 'zope.testing' doesn't have any other changes than this new option (and some others), and no dependency, so this mess up nothing.

I am going to test what I can do for Zope 2.8.

Revision history for this message
Hanno Schlichting (hannosch) wrote :

Not released yet, but today.

Changed in collective.buildout:
status: Confirmed → Fix Released
Revision history for this message
Hanno Schlichting (hannosch) wrote :

Oh, well that was the wrong bug.

Sorry!

Changed in collective.buildout:
status: Fix Released → Confirmed
Revision history for this message
Hanno Schlichting (hannosch) wrote :

The real solution here is to use a newer zope.testing version and --exit-with-status. Works fine with bin/instance test.

Changed in collective.buildout:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.