compiling pgAdmin from source gives an warning about underquoted soundtouch.m4 line

Bug #221205 reported by Tharakan
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
soundtouch (Ubuntu)
Fix Released
Undecided
Unassigned
Hardy
Fix Released
Undecided
Unassigned

Bug Description

Compiling pgAdmin (Front-end tool that comes with PostGresql database) from source, requires a command (bash bootstrap).
Earlier on, this ran fine. But off lately this part of the compile always shows an error about an 'underquoted line' in soundtouch.m4

I quoted the given variable in the soundtouch.m4 file and now that warning is gone.
I have provided the patch below as well.

Hope it helps.

Ubuntu Version:
8.04 (x86-64)

Patch (applied to soundtouch.m4) that resolved the warning:
29c29
< AC_DEFUN([AM_PATH_SOUNDTOUCH],[

---
> AC_DEFUN(AM_PATH_SOUNDTOUCH,[

Warning (See the warning after the aclocal line):
$ bash bootstrap
Checking aclocal...
Checking automake...
Stamping the version number...
Configuring the build system...
+ mkdir config
+ set -x
+ aclocal-1.9
/usr/share/aclocal/soundtouch.m4:29: warning: underquoted definition of AM_PATH_SOUNDTOUCH
  run info '(automake)Extending aclocal'
  or see http://sources.redhat.com/automake/automake.html#Extending-aclocal
+ autoheader
+ automake-1.9 --foreign --add-missing --copy
configure.ac: installing `config/install-sh'
configure.ac: installing `config/missing'
pgadmin/Makefile.am: installing `config/depcomp'
configure.ac:8: installing `config/config.guess'
configure.ac:8: installing `config/config.sub'
+ autoconf

Revision history for this message
Tharakan (tharakan) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :

I can confirm this bug. If you use aclocal or autoreconf and libsoundtouch1-dev is installed, you get this warning. The bug is fixed in upstream version 1.3.1.

TEST CASE: run "touch configure.ac && aclocal" in an empty directory. With the patch there should be no output. Whitout you get this:

/usr/share/aclocal/soundtouch.m4:29: warning: underquoted definition of AM_PATH_SOUNDTOUCH
/usr/share/aclocal/soundtouch.m4:29: run info '(automake)Extending aclocal'
/usr/share/aclocal/soundtouch.m4:29: or see http://sources.redhat.com/automake/automake.html#Extending-aclocal

Benjamin Drung (bdrung)
Changed in soundtouch:
status: New → Confirmed
Revision history for this message
Benjamin Drung (bdrung) wrote :

Version 1.3.0-2.2 does not build on amd64 and lpia, but version 1.3.0-2.1 does. Here is the end of the build log:

test -z "/usr/include/soundtouch" || @mkdir_p@ "/home/skipper/Desktop/soundtouch/soundtouch-1.3.0/debian/tmp//usr/include/soundtouch"
/bin/bash: @mkdir_p@: command not found
make[3]: *** [install-pkgincludeHEADERS] Fehler 127
make[3]: Verlasse Verzeichnis '/home/skipper/Desktop/soundtouch/soundtouch-1.3.0/build-tree/SoundTouch-1.3.0/include'
make[2]: *** [install-am] Fehler 2
make[2]: Verlasse Verzeichnis '/home/skipper/Desktop/soundtouch/soundtouch-1.3.0/build-tree/SoundTouch-1.3.0/include'
make[1]: *** [install-recursive] Fehler 1
make[1]: Verlasse Verzeichnis '/home/skipper/Desktop/soundtouch/soundtouch-1.3.0/build-tree/SoundTouch-1.3.0'
make: *** [common-install-impl] Fehler 2
dpkg-buildpackage: Fehlschlag: fakeroot debian/rules binary gab Fehler-Exitstatus 2
debuild: fatal error at line 1329:
dpkg-buildpackage -rfakeroot -D -us -uc failed

Revision history for this message
Benjamin Drung (bdrung) wrote :

Setting the automake version from 1.7 to 1.10 fix the FTBFS.

Benjamin Drung (bdrung)
Changed in soundtouch:
status: Confirmed → Fix Committed
Revision history for this message
Stephan Rügamer (sruegamer) wrote :

Well,

I think this wouldn't cause really any harm...but having a sane buildsystem makes sense to me.

I'm going to ack this, under the following circumstancas:

First, please check if any of the rdepends of libsoundtouch1c2 will still compile with this check:

shermann@wz-pc-010:~/workspace/leonov-kde/leonov-kde$ apt-cache rdepends libsoundtouch1c2
libsoundtouch1c2
Reverse Depends:
  yatm
  soundstretch
  rezound
  liquidsoap
  libsoundtouch1-dev
  libsoundtouch-ocaml
  ihu
  gstreamer0.10-plugins-bad
  freecycle

Please give a link to some buildlogs for this...

If someone has another opinion, please state here :)

Regards,

\sh

Revision history for this message
Benjamin Drung (bdrung) wrote :

Took gstreamer0.10-plugins-bad and recompiled it without errors.

Revision history for this message
Stephan Rügamer (sruegamer) wrote :

ACK from me.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Fixed in Intrepid.
Fine for me too, but please adhere to DebianMaintainerField specification.

Changed in soundtouch:
status: Fix Committed → Fix Released
status: New → Confirmed
Revision history for this message
Benjamin Drung (bdrung) wrote :

Updated Maintainer Field.

Benjamin Drung (bdrung)
Changed in soundtouch:
status: Confirmed → Fix Committed
Changed in soundtouch:
status: Fix Committed → Confirmed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Version 1.3.0-2.2ubuntu0.1 uploaded to hardy-proposed.

Benjamin Drung (bdrung)
Changed in soundtouch:
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Benjamin Drung (bdrung) wrote :

The package from -proposed works as expected.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Executing aclocal as per test case shows no errors with package in -proposed.

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in soundtouch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.