Patch to allow the 'optimize' build parameter to be used to patch arbitrary CXXFLAGS
Bug #200253 reported by
Adam Williamson
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Won't Fix
|
Low
|
Albert Santoni | ||
Bug Description
This patch allows the 'optimize' parameter to be a string as well as an integer. If it's a string, the string will be passed on as CXXFLAGS. This is useful for distributions which have standard build parameters that are required to be used for all packages (I wrote the patch for the Mandriva package).
You might want to take a different approach to this - add a new parameter, for instance - but the essence of the patch would be a good thing to have.
I also noticed while writing this patch that passing optimize=0 is not optimally handled in the Linux case. It will print "Optimizations enabled..." (as 0 is an integer) but not actually enable any optimizations. I did not address this in my patch, but it's something you might want to fix.
Revision history for this message
| Adam Williamson (awilliamson) wrote | #1 |
Revision history for this message
| Albert Santoni (gamegod) wrote | #2 |
| Changed in mixxx: | |
| assignee: | nobody → gamegod |
| importance: | Undecided → Low |
| status: | New → Confirmed |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #3 |
| Changed in mixxx: | |
| status: | Confirmed → Won't Fix |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #4 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
Will push this into trunk later, patch looks good and should be handy for package maintainers. Thanks for the patch!