landscape-client uses deprecated apt-key

Bug #1990435 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Committed
High
Unassigned

Bug Description

landscape-client still references apt-key, which is deprecated upstream (https://blog.jak-linux.org/2021/06/20/migrating-away-apt-key/):

$ grep -r apt-key .
./dev/landscape-client-vm:apt-key add /root/ppa-key
./landscape/client/manager/aptsources.py: self._run_process("/usr/bin/apt-key", ["add", path]))
./landscape/client/manager/tests/test_aptsources.py: C{AptSources} runs a process with apt-key for every keys in the
./landscape/client/manager/tests/test_aptsources.py: self.assertEqual("/usr/bin/apt-key", command)
./landscape/client/manager/tests/test_aptsources.py: The files created to be imported by C{apt-key} are removed after the
./landscape/client/manager/tests/test_aptsources.py: The files created to be imported by C{apt-key} are removed after the
./landscape/client/manager/tests/test_aptsources.py: If the C{apt-key} command failed for some reasons, the output of the
./landscape/client/manager/tests/test_aptsources.py: If the C{apt-key} fails with a signal, the output of the command is
./landscape/client/manager/tests/test_aptsources.py: If the C{apt-key} command failed for some reasons, the current
$

apt-key will eventually go away, and landscape-client needs to adapt.

Changed in landscape-client (Ubuntu):
status: New → Confirmed
affects: landscape-client (Ubuntu) → landscape-client
Changed in landscape-client:
importance: Undecided → High
Revision history for this message
Juanmi Taboada (juanmitaboada) wrote :

This bug was already addressed by:
- commit fc3b94de26a8b768369532e3df0e71c0519f0574
- Author: Kevin Nasto <email address hidden>
- Date: Wed Oct 19 10:28:23 2022 -0500

The only file missing for an update was:
./dev/landscape-client-vm

I prepared a PR to finish resolving this:
https://github.com/CanonicalLtd/landscape-client/pull/141

Revision history for this message
Juanmi Taboada (juanmitaboada) wrote :

I believe there is one more change to get done in landscape-client.postrm I will push the changes once I review it.

Revision history for this message
Juanmi Taboada (juanmitaboada) wrote :

Ready for review.

Changed in landscape-client:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.