Ubuntu
linux package

ubuntu 22.04 jammy, mlx5, can't change flow steering mode

Bug #1967754 reported by Amir Tzin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Committed
Undecided
Unassigned

Bug Description

on kernel 5.15.0-23-generic devlink cannot show/change flow steering mode

[test case]

# devlink dev param show pci/0000:24:00.0 name flow_steering_mode
pci/0000:24:00.0:
  name flow_steering_mode type driver-specific
    values:

(flow steering mode description is missing beneath "values:")

# devlink dev param set pci/0000:24:00.0 name flow_steering_mode value smfs cmode runtime
Segmentation fault (core dumped)

and also with upstream iproute
# ./iproute2/devlink/devlink dev param set pci/0000:24:00.0 name flow_steering_mode value smfs cmode runtime
Configuration mode not supported

this issue is a degradation introduced by commit from jammy tree
76385c47db37 ("net/mlx5: Accept devlink user input after driver initialization complete")
issue do not repro on v5.15.0 or when the above commit is reverted.

See original description
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1967754

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Amir Tzin (amirtz)
description: updated
Revision history for this message
Amir Tzin (amirtz) wrote :

https://<email address hidden>/

It seems jammy kernel needs cf530217408e ("devlink: Notify users when objects are accessible") from v5.16-rc1
(see link) the old devlink_register (before cf530217408e) implementation do not publish the params so we cannot erase the calls to devlink_params_publish.
i'll update once finished testing with cf530217408e ported.

Revision history for this message
Amir Tzin (amirtz) wrote :

with cf530217408e ("devlink: Notify users when objects are accessible")
i was able to change steering mode

Revision history for this message
dann frazier (dannf) wrote (last edit ):

@Amir: if that fixes the problem for you, would you mind submitting it to <email address hidden>? I've verified that stable 5.15.y is impacted, which is where Ubuntu inherited it from. I also tested upstream 5.15.y w/ cf530217408e applied, and it does seem to fix this issue.

Changed in linux (Ubuntu):
status: Incomplete → Confirmed
dann frazier (dannf)
Changed in linux (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
dann frazier (dannf) wrote :

We decided the best approach was to revert the break patch which is now done in 5.15.y upstream:

commit f1607e13ed715f3b6433361f8ea5d4aa79f03b94
Author: dann frazier <email address hidden>
Date: Thu Apr 7 14:16:42 2022 -0600

    Revert "net/mlx5: Accept devlink user input after driver initialization complete"

Which was released in v5.15.34, and is being tracked for jammy inclusion in bug 1969107.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.