ell 0.48-0.1 doesn't pass unit tests (failed to build)

Bug #1960343 reported by Matthieu Baerts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ell (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hello,

I'm interested by having ell 0.48 fixing a memleak introduce in the previous release.
It has been packaged in Debian, imported in Ubuntu but it looks like the build in Ubuntu fails on amd64:

  (...)
gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -fvisibility=hidden -DUNITDIR=\""./unit/"\" -DCERTDIR=\""./unit/"\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -c -o unit/test-ecdh.o unit/test-ecdh.c
/bin/bash ./libtool --tag=CC --mode=link gcc -fvisibility=hidden -DUNITDIR=\""./unit/"\" -DCERTDIR=\""./unit/"\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wl,-wrap,l_getrandom -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z,relro -Wl,-z,now -o unit/test-ecdh unit/test-ecdh.o ell/libell-private.la
libtool: link: gcc -fvisibility=hidden -DUNITDIR=\"./unit/\" -DCERTDIR=\"./unit/\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wl,-wrap -Wl,l_getrandom -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z -Wl,relro -Wl,-z -Wl,now -o unit/test-ecdh unit/test-ecdh.o ell/.libs/libell-private.a
/usr/bin/ld: /tmp/ccB5sgJf.ltrans0.ltrans.o: in function `__wrap_l_getrandom':
./unit/test-ecdh.c:52: undefined reference to `l_getrandom'
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:1628: unit/test-ecdh] Error 1
make[4]: *** [Makefile:2211: check-TESTS] Error 2
make[3]: *** [Makefile:2716: check-am] Error 2
make[2]: *** [Makefile:2718: check] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:12: override_dh_auto_test] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

See:
https://launchpad.net/ubuntu/+source/ell/0.48-0.1/+build/23141351
https://launchpad.net/ubuntu/+source/ell/0.48-0.1/+build/23141351/+files/buildlog_ubuntu-jammy-amd64.ell_0.48-0.1_BUILDING.txt.gz

It looks like it is not new because the issue was already present in 0.47 but ignored:

  (...)
libtool: link: gcc -fvisibility=hidden -DUNITDIR=\"./unit/\" -DCERTDIR=\"./unit/\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z -Wl,relro -Wl,-z -Wl,now -o unit/test-net unit/test-net.o ell/.libs/libell-private.a
/usr/bin/ld: /tmp/cc6UN0eh.ltrans0.ltrans.o: in function `__wrap_l_getrandom':
./unit/test-ecdh.c:52: undefined reference to `l_getrandom'
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:1628: unit/test-ecdh] Error 1
make[5]: *** Waiting for unfinished jobs....
libtool: link: gcc -fvisibility=hidden -DUNITDIR=\"./unit/\" -DCERTDIR=\"./unit/\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z -Wl,relro -Wl,-z -Wl,now -o unit/test-hwdb unit/test-hwdb.o ell/.libs/libell-private.a
make[4]: *** [Makefile:2211: check-TESTS] Error 2
make[3]: *** [Makefile:2716: check-am] Error 2
make[2]: *** [Makefile:2718: check] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j4 check VERBOSE=1 returned exit code 2
make[1]: [debian/rules:17: override_dh_auto_test] Error 25 (ignored)

See:
https://launchpad.net/ubuntu/+source/ell/0.47-1/+build/23035163
https://launchpad.net/ubuntu/+source/ell/0.47-1/+build/23035163/+files/buildlog_ubuntu-jammy-amd64.ell_0.47-1_BUILDING.txt.gz

When looking at the diff between the two versions, we can see that indeed in v0.47, the tests were ignored in debian/rules.

Were the tests also ignored because of this issue? Is it a known issue? If yes, should we skip the tests only in Ubuntu as everything seems OK on Debian side?

Revision history for this message
Matthieu Baerts (matttbe) wrote :

To answer my own question:

> Is it a known issue?

Apparently yes:

https://lore<email address hidden>/T/#u

Where we can find:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88643
>
> May I suggest that the distro in question figures this out by
> themselves, there's nothing wrong in ell.
>
> If they insist on using LTO, then at least disable it for that test.

I guess LTO should then be disabled for that test.

Jeremy Bícha (jbicha)
tags: added: ftbfs jammy update-excuse
Changed in iwd (Ubuntu):
status: New → Triaged
Jeremy Bícha (jbicha)
Changed in ell (Ubuntu):
status: New → Fix Released
no longer affects: iwd (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.