os-vif

Import IP implementation modules should be done outside the privsep context

Bug #1812090 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-vif
Fix Released
Low
Rodolfo Alonso

Bug Description

When importing the IP module is inside the privsep context, the following error is happening in CentOS:
- CI error: http://logs.openstack.org/47/627047/1/gate/tripleo-ci-centos-7-standalone/8d55ccc/logs/undercloud/var/log/containers/nova/nova-compute.log.txt.gz#_2019-01-02_17_19_28_648
- Error message:
Got error: Class PyRoute2 cannot be found ([\'Traceback (most recent call last):\\n\', \' File "/usr/lib/python2.7/site-packages/oslo_utils/importutils.py", line 32, in import_class\\n return getattr(sys.modules[mod_str], class_str)\\n\', "AttributeError: \'module\' object has no attribute \'PyRoute2\'\\n"])\n']

OpenStack Infra (hudson-openstack)
Changed in os-vif:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
sean mooney (sean-k-mooney) wrote :

triaging as low as i cannot repoduce on either centos7 or ubuntu 18.04

this does show up in kibana
http://logstash.openstack.org/#/dashboard/file/logstash.json?query=module:%5C%22os_vif%5C%22%20AND%20%20%20loglevel:%20%5C%22ERROR%5C%22%20AND%20message:%20%5C%22ImportError%5C%22

but only twice in the last 30 days so this appears to happen very infrequently.

os-vif 1.13.1 came out on december 13 so every tempest job that has deployed nova with libvirt has executed that code in this time without issue.

with that said i will review this with an aim to merging propmtly. we will cut a new version of os-vif before the client libary freeze but it will be a few weeks before we make the next/final os-vif release for stein.

Changed in os-vif:
importance: Undecided → Low
OpenStack Infra (hudson-openstack)
Changed in os-vif:
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → sean mooney (sean-k-mooney)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to os-vif (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/632077

OpenStack Infra (hudson-openstack)
Changed in os-vif:
assignee: sean mooney (sean-k-mooney) → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-vif (master)

Reviewed: https://review.openstack.org/629025
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=843d84c819022621fb6609609d00dc4e02c37780
Submitter: Zuul
Branch: master

commit 843d84c819022621fb6609609d00dc4e02c37780
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jan 7 18:20:28 2019 +0000

    Import IP implementation modules outside privsep context

    If the IP module is loaded inside the privsep context, the following
    error will occur:
      return getattr(sys.modules[mod_str], class_str)
      "AttributeError: 'module' object has no attribute 'PyRoute2'

    Change-Id: I1852038b8d40d4aa52c4f8e661bc78e54e0fc966
    Closes-Bug: #1812090

Changed in os-vif:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to os-vif (master)

Reviewed: https://review.openstack.org/632077
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=9340e59fa0e93c354d570acb03ba21daf39c4825
Submitter: Zuul
Branch: master

commit 9340e59fa0e93c354d570acb03ba21daf39c4825
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jan 21 12:36:35 2019 +0000

    Add test to check os_vif.internal.command.ip.exists

    Related-Bug: #1812090

    Change-Id: Ifc828307bca96850af490f54bf4dc41b02555284

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-vif 1.14.0

This issue was fixed in the openstack/os-vif 1.14.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.