screen-cleanup: check SCREENDIR

Created an attachment (id=1412)
patch for screen-cleanup to check SCREENDIR

Mounting a tmpfs over /var/run is not supported, because it masks directories
which are placed there by the packaging system.

Passing this bug to Martin, because he seems interested in making it work
anyway. :-) Bear in mind that this duplicates packaging data in two places
(i.e., the ownership and mode of the directory), in the .deb and in the init
script, which is undesirable.

Hi!

(In reply to comment #0)
> The current /etc/init.d/screen-cleanup script doesn't check whether SCREENDIR
> (/var/run/screen) exists, which generates a spurious error if it doesn't exist.
> (Screen works without a problem because it creates the directory later on.) This
> situation occurs when /var/run is on a tmpfs (which works with the other init
> scripts).
> A proposed patch is included.

Your patch is not sufficient, screen does _not_ work without the directory:

$ screen
Cannot make directory '/var/run/screen': Permission denied

Which is understandable since screen is only setgid utmp, and /var/run is
root:root 0750. So the patch should be modified to create the directory if it is
not present already and the directory should not be shipped in the deb any more.

 screen (4.0.2-4.1ubuntu2) hoary; urgency=low
 .
   * debian/init: Create /var/run/screen if it does not exist. This makes
     screen work even if /var/run is mounted at a tmpfs. (Ubuntu #6788)

(In reply to comment #3)
[snip]
> Your patch is not sufficient, screen does _not_ work without the directory:
>
> $ screen
> Cannot make directory '/var/run/screen': Permission denied

Ah, sorry I didn't catch that one and thanks for fixing it.