Import errors grouped by sheet and error type, displayed in a textarea
Bug #1020839 reported by
Alan Elkner
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| SchoolTool |
Fix Released
|
Critical
|
Alan Elkner | ||
Bug Description
The old way of spitting out the import errors as they were found yielded a complicated mess, especially if the file was large and the errors, numerous. The textarea will contain the errors summarized by sheet, sub-collated by error message with all the cells of that error message expressed in a single comma-delimitted list wth ranges for cells that are consecutive within a column. The textarea allows the user to copy/paste the errors for sending in an email or saving in a file.
We tried to add a button for automatically copying the contents to the paste buffer, but research showed that the only way was through a library dependent on Flash that worked around a security hole in browsers, so we decided to scratch it.
| Changed in schooltool: | |
| assignee: | nobody → Alan Elkner (aelkner) |
| importance: | Undecided → Critical |
| Changed in schooltool: | |
| status: | New → Fix Committed |
| Changed in schooltool: | |
| milestone: | none → 2.2.0 |
Revision history for this message
| Gediminas Paulauskas (menesis) wrote | #1 |
| Changed in schooltool: | |
| status: | Fix Committed → Fix Released |
| summary: |
- import errors need to be collated and returned in a textarea + Import errors grouped by sheet and error type, displayed in a textarea |
Revision history for this message
| Gediminas Paulauskas (menesis) wrote | #2 |
To post a comment you must log in.
You have introduced a new method, self.error, to add tuples to self.errors. But some errors are still appended as strings, e.g.
))
Such errors result in exception that ends with
File "/home/
for sheet_name, row, col, message in self.errors:
It also embeds row number in the message.