lp:~vila/bzr-gtk/215674-uncommit-save-message

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #215674: uncommit needs an option for saving commit messages

High

Fix Released

Link a bug report

Related blueprints

648. By Vincent Ladeuil on 2009-05-28

Add NEWS entry and do some cleanup.

647. By Vincent Ladeuil on 2009-05-28

Implement commit message saving without modifying bzrlib.

* tests/test_commit.py:
(TestSavedCommitMessages.setUp): Install the post_uncommit hook
for all relevant tests.
(TestUncommitHook.setUp): Use explicit rev-ids to ease debugging.

* commit.py:
Fix imports. Integrate SavedCommitMessagesManager so that we don't
need to modify bzrlib anymore.
(CommitDialog.__init__, CommitDialog._fill_in_files,
CommitDialog._construct_global_message, CommitDialog._do_cancel,
CommitDialog._do_commit): Stop testing can_save_commit_messages,
SavedCommitMessagesManager is always available now.
(SavedCommitMessagesManager): Borrowed from Anne Mohsen's patch.
(save_commit_messages): Implement the post_uncommit hook.

* __init__.py:
Install a lazy hook.

646. By Vincent Ladeuil on 2009-05-28

Fix a leaking dialog windows appearing during the test suite.

* tests/test_commit.py:
(TestReusingSavedCommitMessages._get_commit_dialog): Ensure we
never prompt the user.

645. By Vincent Ladeuil on 2009-05-28

Complete tests around saved commit messages.

* tests/test_commit.py:
(QuestionHelpers): Factor out helpers for embedded dialogs.
(TestSavedCommitMessages): Factor out helpers for saved commit
messages.
(TestReusingSavedCommitMessages): Add tests for saved messages
reuse.

* commit.py:
(CommitDialog._do_cancel): Use the overidable dialog for tests
purposes.

644. By Vincent Ladeuil on 2009-05-28

Tests completed for uncommit.

* tests/test_commit.py:
(TestUncommitHook.setUp): Factor out the setup.
(TestUncommitHook._get_file_info_dict,
TestUncommitHook._get_file_info_revprops,
TestUncommitHook._get_commit_message,
TestUncommitHook._get_file_commit_messages): Add some helpers to
capture the relevant API.
(TestUncommitHook.test_uncommit_one_by_one): Use the three commits
instead of two.
(TestUncommitHook.test_uncommit_all_at_once): New test.

643. By Vincent Ladeuil on 2009-05-27

Start testing patch behavior.

* tests/test_commit.py:
(TestUncommitHook): Start capturing actual behavior with a bzr
patched with Anne's SavedCommitMessagesManager defined in bzrlib.

* commit.py:
(CommitDialog._do_cancel): Reduce duplication.

642. By Vincent Ladeuil on 2009-05-27

Land Anne Mohsen's patch for bug 215674.

641. By Szilveszter Farkas on 2009-05-27

Merge GtkSourceView2 migration patch.

640. By Szilveszter Farkas on 2009-05-27

Added missing entry to NEWS.

639. By Szilveszter Farkas on 2009-05-27

Merge a fix for #294396 by Markus Korn.