Gtk theme link_color is not being used

Reproducible error on the UI.

See also bug 1882988

I think I found the place:

ChangelogViewer.py

line 120

tag = self.buffer.create_tag(None, foreground="blue",
                                     underline=Pango.Underline.SINGLE)

I guess instead of this "blue", we need the @theme_link_color from yaru/adwaita

Since the background color of this application will be set according to the GTK3 theme that the user has chosen, using a static color for link text - which we currently do - will result in that text being difficult or impossible to read for some users. This is unacceptable. So, until someone patches this application to render links according to the theme-set link color, I think it is most appropriate to render links in the normal text color, as we can assume that this is readable. Text being uncolored and readable is preferable to being colored and unreadable. Links are still underlined after applying this patch.

Screenshots of link color before and after applying patch.

The attachment "ChangelogViewer.py.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]