Launchpad itself

JavaScript breaks ability to recover +filebug form data

Bug #553946 reported by Andrea Corbellini
96
This bug affects 15 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned

Bug Description

Steps to reproduce:
1. Go to launchpad.net/project-name/+filebug.
2. Fill the summary and the description of the bug.
3. Click on "Submit Bug Report".

What happens in case of timeout:
You see the "Timeout error" page. But pressing the "back" button on the browser brings you to +filebug with all the fields blank. The only thing to do is to re-write the summary and the description from the beginning and hope that the timeout won't happen again.

Revision history for this message
Leonard Richardson (leonardr) wrote :

This seems like a completely general problem so I'm dispatching it to Foundations rather than the bug product.

affects: launchpad → launchpad-foundations
Revision history for this message
Gary Poster (gary) wrote :

Forms generally handle the back button just fine. I think this is specific to malone. Please clarify the general problem if I am wrong.

affects: launchpad-foundations → malone
Revision history for this message
Deryck Hodge (deryck) wrote :

Gary and I discussed this on IRC. We think the history module in yui3 is all we need to fix this bug. I looked at this module once before when a similar bug came up, and IIRC, something prevented easy use of this module for LP. I'll follow up with mars to confirm we're okay to move forward ourselves. If so, the bugs team will fix this bug and document how to use the module in LP. If not, we'll kick back to foundations for further help.

Cheers,
deryck

Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: story-ajaxify-dupe-finder
Deryck Hodge (deryck)
summary: - Timeouts in +filebug don't let you recover your bug report
+ JavaScript breaks ability to recover +filebug form data
Deryck Hodge (deryck)
tags: added: dhrb
Deryck Hodge (deryck)
Changed in launchpad:
assignee: nobody → Deryck Hodge (deryck)
status: Triaged → In Progress
tags: added: bugjam2010
removed: dhrb
Deryck Hodge (deryck)
Changed in launchpad:
status: In Progress → Triaged
assignee: Deryck Hodge (deryck) → nobody
Revision history for this message
Martin Pool (mbp) wrote :

I think the problem here is that the filebug form does not exist when the page is later shown:

        <div id="filebug-form-container" style="display: none;">
        </div>

It is created later by javascript. I suspect this means it is not covered by the usual form-value-remembering mechanisms in browsers. If that theory is right, it might work better if the form was present but hidden or disabled.

Several other bugs have probably the same root cause such as bug 735290 and bug 513591 and the user frustration in bug 560246 (bearing in mind +filebug may be the first POSTed form after a user logs in.)

Revision history for this message
Martin Pool (mbp) wrote :

I think this was fixed by Ian's sterling work in bug 735290. If not, please undupe.

Changed in launchpad:
status: Triaged → Fix Released
Revision history for this message
Martin Pool (mbp) wrote :

s/undupe/reopen

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.