increment is too high on scroll over the volume slider

Bug #540598 reported by zebul666
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Mathias Brodala

Bug Description

when you mouse scroll over the systray icon, the volume is changed by 5% step. It's hard coded in xlgui/tray.py with self.VOLUME_STEP = 5

whereas when you mouse scroll over the volume slider in the main gui, the step is 20%. It is way TOO MUCH.
it's because in exaile/xlgu/main.py there is incr = self.volume_slider.get_adjustment().page_increment

that could be changed to incr = self.volume_slider.get_adjustment().step_increment

how do you normally do a page increment with the mouse ?

but even with a step increment, it's hard coded in data/ui/main.ui at 10%

so. more consistancy will not hurt, 5% everywhere ?. and please remove the 20%, it could have hurt my ears ;-)

Revision history for this message
Mathias Brodala (mathbr) wrote :

Fixed with r2924. Normal scrolling now changes by 5% and you can also Shift+Scroll to change by 10%.

Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
importance: Undecided → Low
milestone: none → 0.3.1.1
status: New → Fix Committed
Mathias Brodala (mathbr)
Changed in exaile:
milestone: 0.3.1.1 → 0.3.2
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.