tests involving stub_sftp are broken on win32

Bug #526221 reported by Gordon Tyler
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Vincent Ladeuil
2.1
Fix Released
Undecided
Vincent Ladeuil

Bug Description

All tests which make use of bzrlib.tests.stub_sftp fail on win32 with an error similar to the following:

Traceback (most recent call last):
  File "C:\Python26\lib\site-packages\testtools\runtest.py", line 129, in _run_user
    return fn(*args)
  File "C:\Python26\lib\site-packages\testtools\testcase.py", line 370, in _run_setup
    self.setUp()
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\transport_util.py", line 113, in setUp
    url = self.get_url()
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\transport_util.py", line 121, in get_url
    url = super_self.get_url(relpath)
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\__init__.py", line 2264, in get_url
    base = self.get_server().get_url()
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\__init__.py", line 2232, in get_server
    self.start_server(self.__server, self.get_vfs_only_server())
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\__init__.py", line 1026, in start_server
    transport_server.start_server(backing_server)
  File "C:\dev\bzr\bzr.dev\bzrlib\tests\stub_sftp.py", line 447, in start_server
    self._homedir = getcwd()
NameError: global name 'getcwd' is not defined

Related branches

Revision history for this message
Martin Pool (mbp) wrote :

Probably a missing import.

Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Vincent Ladeuil (vila) wrote :

Fallout from a recent refactoring, I have a "fix" for which some tests are still failing but I presume they were also failing before the refactoring.

So, I'll propose a fix without addressing the failing tests.

Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.2.0b1
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
status: In Progress → Fix Released
Revision history for this message
Alexander Belchenko (bialix) wrote :

This bug makes 7 tests in scmproj to fail for me. Can I have the fix in bzr 2.1.x? It's rather serious regression and somewhat blocker for me.

Revision history for this message
Vincent Ladeuil (vila) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.