created account displayName not always shown after successful creation
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
accounts-qml-module (Ubuntu) |
Fix Released
|
High
|
Alberto Mardegan |
Bug Description
When creating a UOA account (either by logging in or registering anew) using the UbuntuOne provider from lp:ubuntuone-credentials (in online-
If I exit to the main system-settings page and click on "Accounts" again to get back to the accounts list, the displayName is shown correctly.
This appears to be a regression, although I'm not sure how. Here's some background:
The displayName wasn't updating correctly a couple of weeks ago, and I found that it was an issue with our provider creating a new account instead of using the one created by the code in NewAccountPage.qml in ubuntu-
I made changes to our code to make sure we find that account and update it instead of creating a new one.
I also made our code set the display name, then call account.sync() and connect the synced signal to the finished signal, so we don't signal finished until the account has been synced, and thus the displayName should definitely be set.
Here are those changes:
https:/
As of that MP, the displayName displayed correctly after success. It no longer does.
Related branches
- David Barth (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 141 lines (+60/-0)4 files modifieddebian/changelog (+6/-0)
src/account-service-model.cpp (+33/-0)
src/account-service-model.h (+6/-0)
tests/tst_plugin.cpp (+15/-0)
Changed in ubuntu-system-settings-online-accounts: | |
assignee: | nobody → Alberto Mardegan (mardy) |
Changed in ubuntu-system-settings-online-accounts: | |
status: | New → Confirmed |
tags: | added: qa-touch u1 |
Reported upstream as http:// code.google. com/p/accounts- sso/issues/ detail? id=204